Reduce fiber switches by queuing callbacks for each tick #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes one delay callback triggering a signal and the next tick hanging then without dispatching the signal.
This avoids two additional fiber switches per tick for non-blocking ticks.
trowski
approved these changes
Jan 9, 2022
|
@WyriHaximus FYI, this has a noticeable performance improvement (+10% to 15% on an HTTP server test) when many watchers are set to be invoked within a single tick. |
bwoebi
approved these changes
Jan 10, 2022
|
@trowski I'm seeing 24-25% performance improvement instead of 10-15% for |
Wow! Even better! I was running a debug build of PHP, so take my benchmark with a grain of salt. 😁 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This massively reduces the number of fibers switches. Before, we usually had a switch to the event loop, another to the callback fiber, called
Suspension::resume(), switched back to the event loop, switched to the microtask fiber, switched to the fiber that suspended to await an event. Now we switch to the event loop, switch to the callback fiber once per tick (if non-blocking and there's no suspend within the callback) and switch to the original fiber.