Fix overflow on large timers #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
commented
Feb 4, 2022
| @@ -210,7 +210,7 @@ protected function activate(array $callbacks): void | |||
| } | |||
|
|
|||
| if ($callback instanceof TimerCallback) { | |||
| $interval = \max(0, $callback->expiration - $now); | |||
| $interval = \min(\max(0, $callback->expiration - $now), \PHP_INT_MAX / 2); | |||
There was a problem hiding this comment.
PHP_INT_MAX / 2 isn't a great solution, and will likely break in 2038 depending on the internal timer used?
|
I made a visual test application for checking memory leaks. Here's how they can currently be played: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit this issue in https://github.com/amphp/file/blob/858c2a46fc799e6775c3e992134eae57d1d58c49/src/Internal/UvPoll.php#L17 with a dummy timer to keep the event loop running.