Fix value of seconds unit in example/benchmark-memory.php #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnsoftbear
changed the title
kelunik
reviewed
Feb 7, 2022
kelunik
reviewed
Feb 12, 2022
kelunik
approved these changes
Feb 13, 2022
WyriHaximus
approved these changes
Feb 13, 2022
|
Thank you for spotting and fixing this 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect second unit in $interval argument of EventLoop::repeat() function instead of millisecond. Script doesn't work as it should according to description in its comment. I've fixed that.