Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace getInfo with reflection API #62

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Replace getInfo with reflection API #62

merged 1 commit into from
Oct 25, 2022

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Oct 13, 2022

This allows applications to get the metrics they want to collect.

@kelunik kelunik added this to the 1.0.0 milestone Oct 13, 2022
@kelunik kelunik mentioned this pull request Oct 13, 2022
Merged
@kelunik kelunik mentioned this pull request Oct 16, 2022
Merged
@kelunik
Copy link
Member Author

kelunik commented Oct 16, 2022

See revoltphp/revoltphp.github.io#4 for the documentation PR.

trowski
trowski approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@trowski trowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I maybe would have added abstract public function getType(): CallbackType to DriverCallback and avoided the match and lookup when looping through callbacks, but it's all internal so doesn't really matter.

@kelunik kelunik mentioned this pull request Oct 20, 2022
Closed
@kelunik kelunik merged commit a515d20 into main Oct 25, 2022
@kelunik kelunik deleted the reflection-api branch October 25, 2022 19:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@trowski trowski

@azjezz azjezz

@WyriHaximus WyriHaximus

Assignees
No one assigned
Labels
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kelunik @trowski @azjezz