Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add runtime check for serious GC bugs in PHP #85

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Add runtime check for serious GC bugs in PHP #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/EventLoop/Internal/AbstractDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ abstract class AbstractDriver implements Driver
/** @var null|\Closure(\Throwable):void */
private ?\Closure $errorHandler = null;

/** @var null|\Closure():mixed */
/** @var null|\Closure():mixed */
private ?\Closure $interrupt = null;

private readonly \Closure $interruptCallback;
Expand All @@ -65,6 +65,13 @@ abstract class AbstractDriver implements Driver

public function __construct()
{
if (\PHP_VERSION_ID < 80117 || \PHP_VERSION_ID >= 80200 && \PHP_VERSION_ID < 80204) {
// PHP GC is broken on early 8.1 and 8.2 versions, see https://github.com/php/php-src/issues/10496
if (!\getenv('REVOLT_DRIVER_SUPPRESS_ISSUE_10496')) {
throw new \Error('Your version of PHP is affected by serious garbage collector bugs related to fibers. Please upgrade to a newer version of PHP, i.e. >= 8.1.17 or => 8.2.4');
}
}

$this->suspensions = new \WeakMap();

$this->internalSuspensionMarker = new \stdClass();
Expand Down