Fix some mining key related bugs #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you elaborate the problem? I don't think it's needed |
|
Well, i mine with the pc miner and i don't have a mining key set. But every time i open the miner, it asks me for the mining key. Since no one has opened an issue, I took it on my own and i fixed it. |
|
Could you check if the same thing isn't happening with AVR miner? |
revoxhere
added
enhancement
|
the same code with the same issue, i'm working on it |
|
Also vs code detects that json itself is not used and someone forget to import random.choice, i'm fixing that |
|
@revoxhere i have my arduino inside another project, can you test it? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying when i open the miner and i have to type the mining key None, so here i fix those tiny bugs