Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use packaging.version where available #210

Merged
merged 2 commits into from
May 3, 2024
Merged

Use packaging.version where available #210

merged 2 commits into from
May 3, 2024

Conversation

offbyone
Copy link
Contributor

Fixes: #209

@offbyone
Copy link
Contributor Author

Note, I could not run the tests locally, so I'm hoping CI bears out my work here:

  File "/Users/offby1/projects/django-test-plus/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1592, in getini
    self._inicache[name] = val = self._getini(name)
                                 ^^^^^^^^^^^^^^^^^^
  File "/Users/offby1/projects/django-test-plus/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1651, in _getini
    return self._getini_unknown_type(name, type, value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/offby1/projects/django-test-plus/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1599, in _getini_unknown_type
    raise ValueError(msg, value)  # pragma: no cover
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: ('unknown configuration type: pathlist', 'test_project/')

(I'm not sure what's going on there, and I'll only dig into it if I need to spend a bunch of iterations on this :) )

offbyone added a commit to offbyone/django-test-plus that referenced this pull request Apr 28, 2024
@offbyone
Use pytest's native python path support
8c5e0d8 
This is added in Pytest 7

Fixes my failure to locally CI as mentioned in revsys#210 (comment)
@offbyone offbyone mentioned this pull request Apr 28, 2024
Merged
@offbyone
Copy link
Contributor Author

#211 will allow these tests to run

@jefftriplett
Copy link
Member

jefftriplett commented May 1, 2024 •
edited
Loading

I think we could safely packaging; python_version >= '3.7' to setup.cfg::setup_requires.

(side-note: I don't see a reason to not drop 3.6 and 3.7 if we are going to do a major upgrade)

@jefftriplett jefftriplett mentioned this pull request May 2, 2024
Merged
jefftriplett pushed a commit that referenced this pull request May 3, 2024
@offbyone
🤝 Use pytest's native python path support (#211)
e24a8e7 
This is added in Pytest 7

Fixes my failure to locally CI as mentioned in #210 (comment)
@jefftriplett jefftriplett force-pushed the use-packaging-instead-of-distutils branch from 09ee21f to bda3b04 Compare May 3, 2024 00:23
@jefftriplett jefftriplett merged commit 93ab347 into revsys:main May 3, 2024
34 checks passed
@jefftriplett
Copy link
Member

@offbyone thank you!

@offbyone offbyone deleted the use-packaging-instead-of-distutils branch May 3, 2024 00:26
jefftriplett added a commit that referenced this pull request May 3, 2024
@jefftriplett @offbyone
🔨 Work off of Chris's branch (#212)
9039f37 
* Use pytest's native python path support

This is added in Pytest 7

Fixes my failure to locally CI as mentioned in #210 (comment)

* 🔨 ⬆️ Updates for uv and expand the matrix

* ⬆️ Upgrade actions versions

* 📝 Fixes uv pip install

* 🔥 Removes 3.6 and 3.7

GitHub dropped support for 3.6 and 3.7

* 🚜 Bumps support

---------

Co-authored-by: Chris Rose <offline@offby1.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.12 is not supported
2 participants
@offbyone @jefftriplett