Issue176: fix filterFeatures() #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgatto
reviewed
Oct 12, 2022
| @@ -309,6 +309,8 @@ filterFeaturesWithFormula <- function(object, filter, na.rm, keep, ...) { | |||
|
|
|||
| ## Internal function that | |||
| .checkFilterVariables <- function(object, vars) { | |||
| ## Ignore variables from the user environment | |||
| vars <- vars[!vars %in% ls(envir = parent.frame(4))] | |||
There was a problem hiding this comment.
What is this number 4 here? Is it always 4?
There was a problem hiding this comment.
Yes it is always four because we only want to include variables from the environment the function was called in (may not always be .GlobalEnv). Here is a "traceback" counter:
0 in .checkFilterVariables()
1 in FilterFeaturesWithFormula()
2 in .local()
3 in filterFeatures()
4 in environment the function was called
There was a problem hiding this comment.
I'm improving the unit test to ensure this is checked.
There was a problem hiding this comment.
Could you also add this information as a comment in the code.
|
Pushed to Bioc |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should solve the issue highlighted in statOmics/msqrob2#42
There is also small code refactoring that will later be required for HDF5 support #171 (sorry for the leak).