util: use the uploaded werkzeug.FileStorage class directly #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, I didn't update the tests, I'll go and fix that. |
abrasive
force-pushed
the
fix-SpooledTemporaryFile-seekable
branch
from
bd7ba57 to
f6a48f2
Compare
|
Fixed the tests. Thanks for setting up such a nice test suite! |
|
I need to get this fixed up and running locally, but are the test failures due to your changes? |
|
Just saw #30 , answered my questions |
|
Please rebase to get tests passing, and I'll merge. |
In newer versions of Werkzeug the uploaded file's stream is a SpooledTemporaryFile. That class doesn't implement the .seekable method, which is called by the Python zipfile library, and everything falls over. This patch avoids the issue by using the FileStorage class directly; as of Werkzeug 0.15 it proxies this method correctly to whatever object is backing the SpooledTemporaryFile. (At least according to the relevant GH issue: pallets/werkzeug#1344 ).
abrasive
force-pushed
the
fix-SpooledTemporaryFile-seekable
branch
from
f6a48f2 to
0f9b513
Compare
|
Good to go. Cheers! |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer versions of Werkzeug the uploaded file's stream is a
SpooledTemporaryFile. That class doesn't implement the .seekable method,which is called by the Python
zipfilelibrary, and everything fallsover.
I experienced this error with Python 3.7.4 and package versions:
This patch avoids the issue by using the
FileStorageclass directly; asof Werkzeug 0.15 it proxies this method correctly to whatever
object is backing the
SpooledTemporaryFile.Relevant GH issue: pallets/werkzeug#1344
This may be the cause of #27.