Use case-insensitive Windows environment #8
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows environment entries are case-sensitive. It is up to the reader to do a case-insensitive search if required. This commit does that so that `SystemRoot` and `SYSTEMROOT` can be considered equally.
|
@emillon could you review? |
Closed
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jan 20, 2023
CHANGES: * Passthrough case-insensitive PATH and SYSTEMROOT on Windows (@emillon, @jonahbeckford, rgrinberg/curly#6, rgrinberg/curly#8) * Passthrough PATH to Unixes too. (@bikal, rgrinberg/curly#12) * Add `?follow_redirects` argument to `run` and related functions (@rawleyfowler, rgrinberg/curly#5).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #6
On Windows environment entries are case-sensitive. It is up to the reader to do a case-insensitive search if required. This PR does a case-insensitive search so that
SystemRootandSYSTEMROOTare both recognized.Also had to bump up OCaml requirements from 4.02.3 to 4.03.0 since using
String.lowercase_ascii.