Fix possible read out of bounds in ucs2_to_utf8 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
approved these changes
Sep 29, 2021
Check that the current character is not the null character after ensuring we are not beyond the end of the buffer. Signed-off-by: Dan Robertson <dan@dlrobertson.com>
frozencemetery
force-pushed
the
read-oob-to-utf8
branch
from
ae57645
to
b6bb490
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the current character is not the null character after
ensuring we are not beyond the end of the buffer.
Signed-off-by: Dan Robertson dan@dlrobertson.com