Add support for RSA3072 and RSA4096.

[vathpela]

No description provided.

[Blarse]

Hi,

I've noticed that your PR does not take into account the change of the ASN.1 type in bundle_signature(). The type offset in the DER encoded signature depends on the size of the signature.

I propose the following patch:

--- a/src/efikeygen.c
+++ b/src/efikeygen.c
@@ -141,7 +141,8 @@ bundle_signature(cms_context *cms, SECItem *sigder, SECItem *data,
                errx(1, "could not encode certificate: %s",
                        PORT_ErrorToString(PORT_GetError()));
 
-       sigder->data[sigder->len - 261] = DER_BIT_STRING;
+       //Note: offset is signature size + 5 bytes for DER encoding
+       sigder->data[sigder->len - (signature->len + 5)] = DER_BIT_STRING;
 
        return 0;
 }

Other than that this PR look good to me, is there any reason not to merge it yet?

[vathpela]

Well, it wasn't actually working when I tried it, possibly due to this exact issue. Hopefully I'll get back to it in a week or two and figure out why.

[vathpela]

Yep, that change gets me from:
efikeygen: efikeygen.c:main:1287: could not import signature: security library: invalid arguments.
to working key generation and signatures that validate. Thanks!