Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BuildWorkflowInput() blocks because it does not check ctx.Done() when sending data to the channel #10

Closed
vistart opened this issue May 9, 2024 · 0 comments
Closed

BuildWorkflowInput() blocks because it does not check ctx.Done() when sending data to the channel #10

vistart opened this issue May 9, 2024 · 0 comments
Assignees
@vistart
Labels
bug Something isn't working simple.DAG All issues involving simple.DAG
Milestone
v1.0.1

Comments

@vistart
Copy link
Contributor

vistart commented May 9, 2024

In extremely rare cases, blocking occurs in the BuildWorkflowInput() method when sending data to the channel.

Test case: https://github.com/rhosocial/go-dag/actions/runs/9006182349/job/24743123029
@vistart vistart added bug Something isn't working simple.DAG All issues involving simple.DAG labels May 9, 2024
@vistart vistart added this to the v1.1.0 milestone May 9, 2024
@vistart vistart self-assigned this May 9, 2024
vistart added a commit that referenced this issue May 9, 2024
@vistart
try to solve #10
ec5a6b3
@vistart vistart modified the milestones: v1.1.0, v1.0.1 May 9, 2024
@vistart vistart closed this as completed May 10, 2024
@vistart vistart mentioned this issue May 10, 2024
Merged
vistart added a commit that referenced this issue May 15, 2024
@vistart
try to solve #10
8a494fe 
related to https://github.com/rhosocial/go-dag/actions/runs/9079256736/job/24948073753
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vistart vistart

Labels
bug Something isn't working simple.DAG All issues involving simple.DAG
Projects
None yet
Milestone
v1.0.1
Development

No branches or pull requests
1 participant
@vistart