Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Panic when max history is set to 0 #4

Closed
Volkalex28 opened this issue Oct 3, 2022 · 1 comment
Closed

Panic when max history is set to 0 #4

Volkalex28 opened this issue Oct 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Volkalex28
Copy link
Contributor

Volkalex28 commented Oct 3, 2022

If set the maximum amount of history to 0, then according to the documentation, undo / redo should be disabled. Actually there is a panic at change of the text in TextArea. This is because the value in history.rs:115 is out of range. I consider it necessary to add an additional condition for checking compliance with the boundaries

@rhysd rhysd added the bug Something isn't working label Oct 4, 2022
@rhysd
Copy link
Owner

rhysd commented Oct 4, 2022

Thanks for reporting this. I'll take a look.

@rhysd rhysd closed this as completed in 0ca8573 Oct 4, 2022
rhysd added a commit that referenced this issue Oct 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants