-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Alignment for TextArea #3
Conversation
Can you describe the motivation? Setting center or right alignment to text editor sounds strange for me. I don't think that alignments other than left work with line numbers well. |
Good day. Alignment seemed like a good idea to me when this library is used in single line mode. If I want to embed a field somewhere to change the row, I might need to align it to the center or to the right. For example, I needed it to change table cells. Some of the data is strings and numbers. Your library is best suited for this role, but since the cells are aligned in the center according to the style of the table, it is necessary to align in your widget too. If you want I can test line number alignment when I get a chance and/or fix this functionality |
Thanks for the explanation. I understood you use case and it sounds reasonable. Let me try this branch on my side before merging.
Your use case doesn't seem to need line numbers, so I think simply disabling line numbers would be sufficient. After merging this branch, I'll add the implementation. |
@Volkalex28 Can you fix formatter issue?
|
Yes. I will check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now I have time. I'll fix linter warnings after merging this.
v0.1.6 was released. |
No description provided.