Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Alignment for TextArea #3

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Alignment for TextArea #3

merged 3 commits into from
Sep 28, 2022

Conversation

Volkalex28
Copy link
Contributor

No description provided.

@rhysd
Copy link
Owner

rhysd commented Sep 27, 2022

Can you describe the motivation? Setting center or right alignment to text editor sounds strange for me.

I don't think that alignments other than left work with line numbers well.

@Volkalex28
Copy link
Contributor Author

Can you describe the motivation? Setting center or right alignment to text editor sounds strange for me.

I don't think that alignments other than left work with line numbers well.

Good day.

Alignment seemed like a good idea to me when this library is used in single line mode. If I want to embed a field somewhere to change the row, I might need to align it to the center or to the right. For example, I needed it to change table cells. Some of the data is strings and numbers. Your library is best suited for this role, but since the cells are aligned in the center according to the style of the table, it is necessary to align in your widget too.

If you want I can test line number alignment when I get a chance and/or fix this functionality

@rhysd
Copy link
Owner

rhysd commented Sep 28, 2022

Thanks for the explanation. I understood you use case and it sounds reasonable. Let me try this branch on my side before merging.

If you want I can test line number alignment when I get a chance and/or fix this functionality

Your use case doesn't seem to need line numbers, so I think simply disabling line numbers would be sufficient. After merging this branch, I'll add the implementation.

@rhysd
Copy link
Owner

rhysd commented Sep 28, 2022

@Volkalex28 Can you fix formatter issue?

cargo fmt

@Volkalex28
Copy link
Contributor Author

@Volkalex28 Can you fix formatter issue?

cargo fmt

Yes. I will check

Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now I have time. I'll fix linter warnings after merging this.

@rhysd rhysd merged commit 3387f93 into rhysd:main Sep 28, 2022
@rhysd
Copy link
Owner

rhysd commented Sep 28, 2022

v0.1.6 was released.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants