add an option to show cursor and placeholder together #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu08
commented
Jul 26, 2024
Comment on lines
+123
to
+127
| #[cfg(any( | ||
| feature = "tuirs-crossterm", | ||
| feature = "tuirs-termion", | ||
| feature = "tuirs-no-backend", | ||
| ))] |
There was a problem hiding this comment.
In tui-rs, Text does not have push_span method, so I did not support them.
When I did not put above cfg, I got this error.
error[E0599]: no method named `push_span` found for struct `tui::text::Text` in the current scope
--> src/widget.rs:[12](https://github.com/kyu08/tui-textarea/actions/runs/10096172842/job/27918026333#step:18:13)9:22
|
129 | text.push_span(self.0.placeholder.as_str());
| ^^^^^^^^^ method not found in `Text<'_>`
For more information about this error, try `rustc --explain E0599`.
error: could not compile `tui-textarea` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `tui-textarea` (lib test) due to 1 previous error
|
Thank you for implementing this. I feel this behavior should be default. I will remove the option and make this as default behavior after merging this PR. |
rhysd
approved these changes
Jul 31, 2024
rhysd
added a commit
that referenced
this pull request
Jul 31, 2024
|
I made this default behavior at 00f0010 |
|
@rhysd |
|
Okay, I'll announce the next release in this issue thread so that you can notice it. |
|
Thank you so much! |
|
Thanks for fixing image ratio. 🙏 |
|
This feature was included in v0.5.2 release. |
|
@rhysd |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I added an option to show cursor with placeholder. This is disabled by default.
Motivation
I feel it is more common that cursor and placeholder are shown together. Also users can understand easily they can input.