Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename locale to site on redirects table #156

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Rename locale to site on redirects table #156

merged 4 commits into from
Jan 8, 2024

Conversation

vluijkx
Copy link
Contributor

@vluijkx vluijkx commented Jan 6, 2024

Advantages:

  • More consistent with statamic/eloquent-driver.
  • Fixes issue where eloquent-redirect could not be created because of validation rule in blueprint which queries based on a site column.
  • Fixes issue when using eloquent redirects with multisite. The multisite filter on the index-page expects a site column.

@vluijkx vluijkx changed the title Rename locale to site on redirects table Rename locale to site on redirects table Jan 7, 2024
@vluijkx vluijkx changed the title Rename locale to site on redirects table Rename locale to site on redirects table Jan 7, 2024
@riasvdv riasvdv merged commit 372e1ab into riasvdv:main Jan 8, 2024
@riasvdv
Copy link
Owner

riasvdv commented Jan 8, 2024

Thanks a lot!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants