Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

detect network change on Mac Catalina #89

Merged
merged 2 commits into from
Nov 2, 2019
Merged

detect network change on Mac Catalina #89

merged 2 commits into from
Nov 2, 2019

Conversation

richardschneider
Copy link
Owner

Only do magic from @eshvatskyi on Windows. Removing/Adding event handler causes
infinitive recursion on Catalina. See #87

Only do magic from @eshvatskyi on Windows.  Removing/Adding event handler causes
infinitive recursion on Catalina.
@richardschneider richardschneider changed the title detect network change on Mac Catatlina detect network change on Mac Catalina Nov 1, 2019
@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #89 into master will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   90.52%   91.11%   +0.59%     
==========================================
  Files          10       10              
  Lines         517      518       +1     
==========================================
+ Hits          468      472       +4     
+ Misses         49       46       -3
Impacted Files Coverage Δ
src/MulticastService.cs 91.57% <100%> (+0.04%) ⬆️
src/MulticastClient.cs 85.24% <0%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81281a8...4ae684c. Read the comment docs.

@richardschneider
Copy link
Owner Author

@eshvatskyi are you happy with this?

@eshvatskyi
Copy link
Contributor

@eshvatskyi are you happy with this?
I'm sorry, but I didn't get, is this an irony, Catalina just launched, and it looks, has more bugs than windows )), don't claim me ))

@richardschneider richardschneider merged commit 20f4e40 into master Nov 2, 2019
@richardschneider richardschneider deleted the catalina branch November 5, 2019 00:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants