Addressed a compiler error, changes the project icon url to use embedded icon, and added additional target framework #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a compiler error caused by an ambiguous reference Switched over to using embedded icon (projectIconUrl is deprecated) Changed IniParser.csproj to always generate package
ravensorb
changed the title
|
Hey @ravensorb thanks for the contribution! The netcore3.1 target framework is making the mono build, is adding that framework a must? |
|
This is happening because of the Travis CI configuration, please change the version of the SDK at line 11 in .travis.yml#L11 to a newer version (at least for compiling with .NET Core 3.1). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added target framework for .netcoreapp3.1
Fixed a compiler error caused by an ambiguous reference
Switched over to using embedded icon (projectIconUrl is deprecated)
Changed IniParser.csproj to always generate package