Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support CJK Unified Ideographs Extension G in charset_filter #392

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/rime/gear/charset_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ bool is_extended_cjk(uint32_t ch)
(ch >= 0x2B740 && ch <= 0x2B81F) || // CJK Unified Ideographs Extension D
(ch >= 0x2B820 && ch <= 0x2CEAF) || // CJK Unified Ideographs Extension E
(ch >= 0x2CEB0 && ch <= 0x2EBEF) || // CJK Unified Ideographs Extension F
(ch >= 0x30000 && ch <= 0x3134A) || // CJK Unified Ideographs Extension G
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the range to match the standard:
https://en.wikipedia.org/wiki/CJK_Unified_Ideographs_Extension_G

Range | U+30000..U+3134F

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#393 edited

(ch >= 0x2F800 && ch <= 0x2FA1F)) // CJK Compatibility Ideographs Supplement
return true;

Expand Down