Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(key_binder): add when: predicting condition #751

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

lotem
Copy link
Member

@lotem lotem commented Oct 29, 2023

the new condition when: predicting allow paging key binding to comma, period keys to be disabled when the active menu has tag prediction.

it's used with the predictor component in the librime-predict plugin. see updates in data/minimal/default.yaml for example configuration.

the new condition `when: predicting` allow paging key binding to comma,
period keys to be disabled when the active menu has tag `prediction`.

it's used with the `predictor` component in the librime-predict plugin.
see updates in data/minimal/default.yaml for example configuration.
@lotem lotem requested review from eagleoflqj and fxliang October 29, 2023 15:54
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected in rime_api_console.

@eagleoflqj eagleoflqj merged commit 3bc65c9 into rime:master Oct 29, 2023
@fxliang
Copy link
Contributor

fxliang commented Oct 30, 2023

with this PR merged, looks like that librime-predict has been embedded not plugin. )

@lotem lotem deleted the predicting-condition branch November 1, 2023 09:25
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
the new condition `when: predicting` allows paging key binding to comma,
period keys to be disabled when the active menu has tag `prediction`.

it's used with the `predictor` component in the librime-predict plugin.
see updates in data/minimal/default.yaml for example configuration.
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
the new condition `when: predicting` allows paging key binding to comma,
period keys to be disabled when the active menu has tag `prediction`.

it's used with the `predictor` component in the librime-predict plugin.
see updates in data/minimal/default.yaml for example configuration.
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
the new condition `when: predicting` allows paging key binding to comma,
period keys to be disabled when the active menu has tag `prediction`.

it's used with the `predictor` component in the librime-predict plugin.
see updates in data/minimal/default.yaml for example configuration.
fxliang pushed a commit to fxliang/librime that referenced this pull request Feb 2, 2024
the new condition `when: predicting` allows paging key binding to comma,
period keys to be disabled when the active menu has tag `prediction`.

it's used with the `predictor` component in the librime-predict plugin.
see updates in data/minimal/default.yaml for example configuration.
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
the new condition `when: predicting` allows paging key binding to comma,
period keys to be disabled when the active menu has tag `prediction`.

it's used with the `predictor` component in the librime-predict plugin.
see updates in data/minimal/default.yaml for example configuration.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants