Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace std::bind with lambda to increase readability #903

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

As the title.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@WhiredPlanck WhiredPlanck force-pushed the no-bind branch 2 times, most recently from 583fa9e to 4c21d4d Compare June 22, 2024 14:29
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in C++, so take my suggestions with a grain of salt. I think we should avoid capture-by-reference whenever possible, and be explicit about capturing this.

Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think this is good to go.

(BTW, I've been using a local build for some time and there's no regression. Just a datapoint.)

@ksqsf ksqsf merged commit 58ee93f into rime:master Jun 30, 2024
10 checks passed
@WhiredPlanck WhiredPlanck deleted the no-bind branch July 14, 2024 02:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants