Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Optimize user dictionary lookup performance #940

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Optimize user dictionary lookup performance #940

merged 1 commit into from
Sep 29, 2024

Conversation

ksqsf
Copy link
Member

@ksqsf ksqsf commented Sep 28, 2024 •
edited
Loading

Essentially adding a cache for table_->GetSyllableById.

Before:

CleanShot 2024-09-28 at 22 42 29@2x

After:

CleanShot 2024-09-28 at 22 43 04@2x

@ksqsf ksqsf requested a review from lotem September 28, 2024 20:43
@ksqsf ksqsf changed the title optimize DfsLookup Optimize user dictionary lookup performance Sep 28, 2024
lotem
lotem approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

厉害

@ksqsf ksqsf merged commit aaaaaec into master Sep 29, 2024
10 checks passed
@ksqsf ksqsf deleted the optimize branch September 29, 2024 03:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksqsf @lotem