masking maskmax in breakpoints test #358
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in rocket-chip, reading tdata1 will return the value "4" in the maskmax field.
This happens because of this line:
https://github.com/chipsalliance/rocket-chip/blob/7f214d564a57d3b1fa63e67a42a64629e76d53a2/src/main/scala/rocket/Breakpoint.scala#L30
Thus, the breakpoint.S test was always skipped and did not work.