[debug] Reserve triggers propperly in HwbpManual #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
force-pushed
the
en-sc/reserve-trigger-fix-propper
branch
from
ae50b69 to
ee10e9c
Compare
aap-sc
reviewed
Sep 6, 2024
riscv-collab/riscv-openocd#1111 introduces a change in OpenOCD behavior: a manual trigger should be manually removed to step/resume from it. This was not concidered in previous stop-gap solutions (76ff703 and 8cc4918) This commit: 1. Determines if `reserve trigger` is supported by the target. This can be removed once riscv-collab/riscv-openocd#1111 is merged. 2. Marks `HwbpManual` test as not applicable in case `reserve trigger` is not supported. 3. Accounts for the change in OpenOCD's behavior when stepping from a manual BP. 4. Cleans up some minor mistakes in `HwbpManual`
en-sc
force-pushed
the
en-sc/reserve-trigger-fix-propper
branch
from
ee10e9c to
1839696
Compare
aap-sc
approved these changes
Sep 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riscv-collab/riscv-openocd#1111 introduces a change in OpenOCD behavior: a manual trigger should be manually removed to step/resume from it.
This was not concidered in previous stop-gap solutions (76ff703 and 8cc4918)
This commit:
reserve triggeris supported by the target. This can be removed once target/riscv: manage triggers available to OpenOCD for internal use riscv-collab/riscv-openocd#1111 is merged.HwbpManualtest as not applicable in casereserve triggeris not supported.HwbpManual