Improve table: Compressed instruction formats #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table "Compressed 16-bit RVC instruction formats" header indicating the bits corresponding to each column only aligns properly with the first row (CR format), but doesn't reflect the boundaries of other rows (for example, funct3 or rs1'), making it hard to read. Signed-off-by: cousteau <cousteaulecommandant@gmail.com>
aswaterman
approved these changes
Oct 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table "Compressed 16-bit RVC instruction formats" header indicating the bits corresponding to each column only aligns properly with the first row (CR format), but doesn't reflect the boundaries of other rows (for example, funct3 or rs1'), making it hard to read.
This PR fixes that by distributing the bit indexes on the table header across the "actual" table columns (unmerged cells), so that it's clear which bits each field spans in every compressed instruction format, not just CR.
This is a really minor stylistic edit that you may want to squash into a future commit (or even just apply the change manually in a future edit).