Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(wasm): experimental support for WASI #733

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

wangrunji0408
Copy link
Member

Signed-off-by: Runji Wang wangrunji0408@163.com

brew install wasmer
rustup target add wasm32-wasi
cargo b --target wasm32-wasi --no-default-features
wasmer target/wasm32-wasi/debug/risinglight.wasm

risinglight-wasi

Signed-off-by: Runji Wang <wangrunji0408@163.com>
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, good work!

@@ -13,7 +12,7 @@ pub struct DatabaseWrapper;
impl sqlplannertest::PlannerTestRunner for DatabaseWrapper {
async fn run(&mut self, test_case: &ParsedTestCase) -> Result<String, Error> {
if !test_case.tasks.is_empty() {
let db = Database::new_on_disk(SecondaryStorageOptions::default_for_test()).await;
let db = Database::new_in_memory();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-memory engine might not support predicate pushdown on table scan. I still want to keep new_on_disk with in-memory backend here.

@skyzh
Copy link
Member

skyzh commented Jul 26, 2023

I was working on some WASM-related things recently I would prefer compiling it using wasm-pack so that it can run in the browser.

@wangrunji0408
Copy link
Member Author

I was working on some WASM-related things recently I would prefer compiling it using wasm-pack so that it can run in the browser.

Just curious about what it is? (if not confidential) 👀
Cuz we are going to explore WASM UDF recently. 🤡

@skyzh
Copy link
Member

skyzh commented Jul 26, 2023

see prisma-engines :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants