-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(deps): update librdkafka to v2.3.0 #15313
Conversation
Signed-off-by: Runji Wang <wangrunji0408@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: What I confirmed is apply the patch of confluentinc/librdkafka#4460 can resolve the hang problem of rust-rdkafka. We need to examine whether v2.3.0 can work again. cc @shanicky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to upgrade this to main. But I have concerns that cherry-picking this to 1.7 might introduce side-effects and we don't have large enough time window to test thoroughly. IMO the most serious way should be only cherry-picking the fix PR of the dependency and use patched version. But I know it's more troublesome than simply upgrading.
Just want to mention this risk. I'm fine to proceed in whatever way.
Please have a quick review on the upstream changelog. Especially for this section, to make sure there will be no side-effect on us:
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
to fix #15235
Changelog
https://github.com/confluentinc/librdkafka/releases/tag/v2.3.0
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.