Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fallback to random port if the default is taken. #330

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

Almo7aya
Copy link
Contributor

@Almo7aya Almo7aya commented Mar 4, 2019

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other: <!-- Please describe: -->

What is the current behavior?

Issue Number: #328

What is the new behavior?

Describe in issue: #328

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Almo7aya
Copy link
Contributor Author

Almo7aya commented Mar 9, 2019

Will you review this PR?

@nash-ye
Copy link

nash-ye commented Mar 12, 2019

Please, response to @Almo7aya . 👍

@lilililee
Copy link

lilililee commented Mar 28, 2019

Does this PR can work as well when set port again and again? it seems can adjust port only once.

@Almo7aya
Copy link
Contributor Author

@lilililee It will 5500 ++ until it finds an open port!

@lilililee
Copy link

@Almo7aya Nice!👍 Full of expectation it release~

@ritwickdey ritwickdey merged commit 0f34e13 into ritwickdey:master Apr 8, 2019
@ritwickdey
Copy link
Owner

I'm feeling seriously sorry when I this PR. Really awesome work!! 💘

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants