Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure defaults are passed along for multiselect arrays when minItems… #1264

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Ensure defaults are passed along for multiselect arrays when minItems… #1264

merged 3 commits into from
Jun 3, 2019

Conversation

fsteger
Copy link
Contributor

@fsteger fsteger commented Apr 24, 2019

… present (#1258)

Reasons for making this change

When minItems is present for multi select array fields, the default value returned was always an empty array.

Addresses issue #1258

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace
Copy link
Member

@fsteger thanks for the PR -- can you add a test for the case in which default is an array of items (such as the example in issue #1258)? It looks like the test you added is a duplicate of an existing test.

@epicfaace
Copy link
Member

Thanks!

@epicfaace epicfaace merged commit 41fce4a into rjsf-team:master Jun 3, 2019
@fsteger fsteger deleted the issue-1258 branch June 24, 2019 12:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants