Fix nested dependencies updating #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
commented
Jun 17, 2019
| @@ -595,6 +618,12 @@ function resolveDependencies(schema, definitions, formData) { | |||
| dependencyValue | |||
| ); | |||
| } | |||
| return processDependencies( | |||
There was a problem hiding this comment.
Makes this function recursive so that once a dependency is resolved, it goes through all the dependencies again.
edi9999
approved these changes
Jun 19, 2019
8 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1235.
If this is related to existing tickets, include links to them as well.
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style