-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding support for $ref pointers to additionalProperties. #1402
Adding support for $ref pointers to additionalProperties. #1402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Can you also add a test in Form_test.js
, so that the logic you added in ObjectField.js
is covered?
@epicfaace Done! |
By the way, here's a playground link to an example that doesn't work currently on the main playground using $ref with additionalProperties. (Testing it on the deploy preview works fine!) |
Thanks! |
I just forked this and found there is an issue w monaco-editor-webpack-plugin version - took the '^' out and it compiled - I am new to contributing hopefully this is the correct format |
Reasons for making this change
This adds support for
$ref
pointers onadditionalProperties
objects.Checklist