Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

semantic-ui: add submit button, email, url, date widgets #2224

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

jacqueswho
Copy link
Contributor

Reasons for making this change

Features:

  • added submitButton
  • added Date and DateTime Widgets
  • added email Widget
  • added URLWidget

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@jacqueswho jacqueswho mentioned this pull request Feb 8, 2021
7 tasks
@jacqueswho jacqueswho added the semantic-ui semantic-ui related theme issue label Feb 11, 2021
@epicfaace epicfaace self-assigned this Feb 15, 2021
@ErQrYfkrju
Copy link

@epicfaace @agustin107 ping

@ErQrYfkrju
Copy link

Hello @agustin107 @epicfaace @jacqueswho any news on this pull request?

@jacqueswho
Copy link
Contributor Author

Hello @agustin107 @epicfaace @jacqueswho any news on this pull request?

sorry @ErQrYfkrju cant do anything. just waiting.

feat: include widgets

Revert

test: updates tests
@jacqueswho jacqueswho force-pushed the feature/add_widgets branch from 8262e8c to 68d80c6 Compare June 23, 2021 14:05
@jacqueswho jacqueswho requested a review from epicfaace June 23, 2021 14:53
@jacqueswho
Copy link
Contributor Author

@epicfaace please can this be merged

@epicfaace epicfaace changed the title feat: add submit button, email, url, date widgets semantic-ui: add submit button, email, url, date widgets Aug 12, 2021
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Apologies for the delay!

@epicfaace epicfaace merged commit de8d0ff into master Aug 12, 2021
@epicfaace epicfaace deleted the feature/add_widgets branch August 12, 2021 12:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
awaiting response semantic-ui semantic-ui related theme issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants