Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove passing down context and use TreeItem as base class #35

Closed
rkotze opened this issue Apr 26, 2020 · 0 comments
Closed

Remove passing down context and use TreeItem as base class #35

rkotze opened this issue Apr 26, 2020 · 0 comments
Assignees
@rkotze
Labels
Code improvements Better code quality, standards, testing, maintenance

Comments

@rkotze
Copy link
Owner

rkotze commented Apr 26, 2020

Summary

Remove the need to pass context into tree provider objects, author, coAuthors and groups. This will make the code separate the concerns better, reduce complexity and overall make the code cleaner.
@rkotze rkotze self-assigned this Apr 26, 2020
@rkotze rkotze added the Code improvements Better code quality, standards, testing, maintenance label Apr 26, 2020
rkotze added a commit that referenced this issue Apr 26, 2020
@rkotze
🎨 Start with replacing tree node
146b0fd 
Define top level groups with better class names and a function to resolve children.

Remove context to help resolve icon path.

#35
rkotze added a commit that referenced this issue Apr 30, 2020
@rkotze
Helpful tooltips for toplevel selection
76e9283 
#35
rkotze added a commit that referenced this issue Apr 30, 2020
@rkotze
Match implementation file name
37a29c9 
#35
rkotze added a commit that referenced this issue Apr 30, 2020
@rkotze
Create author class using TreeItem
6e83e95 
#35
rkotze added a commit that referenced this issue Apr 30, 2020
@rkotze
CoAuthors class to use TreeItem
699cbdc 
#35
rkotze added a commit that referenced this issue May 3, 2020
@rkotze
Repo authors using TreeItem
eda0b6a 
#35
rkotze added a commit that referenced this issue May 3, 2020
@rkotze
Remove all unused author classes
cdd2486 
Migrated to just using TreeItem has base class.

#35
rkotze added a commit that referenced this issue May 3, 2020
@rkotze
Tree node no longer used
4f34a26 
#35
rkotze added a commit that referenced this issue May 3, 2020
@rkotze
🎨 Group all co-author related files
c39520a 
Add name prop for author class consistency

#35
rkotze added a commit that referenced this issue May 3, 2020
@rkotze
No author class has getTreeItem as element is a TreeItem
fb7dd3c 
No longer need vscode context to help resolve icon file paths.

#35
rkotze added a commit that referenced this issue May 3, 2020
@rkotze
🎨 Remove dependency on vs code context
7af1d69 
Overall better code structure which is easier to reason about.

#35
@rkotze rkotze closed this as completed May 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rkotze rkotze

Labels
Code improvements Better code quality, standards, testing, maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rkotze