Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set author and co-authors using git mob core #106

Merged
merged 27 commits into from
Oct 22, 2023
Merged

Conversation

rkotze
Copy link
Owner

@rkotze rkotze commented Apr 30, 2023

Description

Use git mob core features to set selected co-authors and primary author.

Migrate flowing key functions from git-mob to git-mob-core:

import { gitMessage, gitMessagePath } from '../src/git-message';
import { getCoAuthors, isCoAuthorSet } from '../src/git-mob-commands';

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • All tests and linting (npm run checks) has passed locally and any fixes were made for failures
  • I kept my pull requests small so it can be reviewed easier

Pull request type

Please check the type of change your PR introduces:

  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

Does this introduce a breaking change?

  • Yes
  • No

@rkotze rkotze self-assigned this Apr 30, 2023
rkotze added 8 commits May 27, 2023 16:04
When selecting co-authors from list in git mob core
use git mob core saveNewCoAuthors() to add missing authors
Save missing authors will find authors from GitHub.

setCoauthors from the core will manage the work to set selected co authors and throw errors.
Git mob core workout if you're using local template and display warning.
@rkotze rkotze force-pushed the integrate-core-git-mob branch from ae1db43 to f7c94fc Compare May 28, 2023 15:00
@rkotze rkotze marked this pull request as ready for review October 21, 2023 22:08
@rkotze rkotze merged commit 2ffd6af into master Oct 22, 2023
@rkotze rkotze deleted the integrate-core-git-mob branch October 22, 2023 14:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant