Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(pre-commit): Remove blob/master information from raw git reposito… #124

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix(pre-commit): Remove blob/master information from raw git reposito… #124

merged 1 commit into from
Feb 4, 2024

Conversation

abelazo
Copy link
Contributor

@abelazo abelazo commented Feb 3, 2024

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • All tests and linting (npm run checks) has passed locally and any fixes were made for failures
  • I kept my pull requests small so it can be reviewed easier

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behaviour?

Removed Github references (blob/master) from .pre-commit-config.yaml as pre-commit seems to checkout the repository in raw git format.

Issue URL: Issue #123

What is the new behaviour?

pre-commit does not raise an error when trying to reference prepare-commit-msg-nodejs

  • Bugfix

Does this introduce a breaking change?

  • Yes
  • No

Other information

Change has been tested successfully locally with pre-commit.
I haven't tested git-mob core or the VSstudio extension.

@rkotze rkotze merged commit 68fdc54 into rkotze:master Feb 4, 2024
4 checks passed
@rkotze
Copy link
Owner

rkotze commented Feb 4, 2024

Thanks for your contribution.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants