Change values of FREQ when get the RFC string to match the convention

[antitoine]

Hi,

In the RFC convention the frequency is a string ("WEEKLY", "YEARLY" ...) not a number when we want to get the RRule string : https://tools.ietf.org/html/rfc5545#page-39

This pull request fix this example :

$rrule = new RRule([
    'FREQ' => 'MONTHLY',
    'INTERVAL' => 1,
    'DTSTART' => '2015-06-01',
    'COUNT' => 6
]);
$copyRrule = new RRule($rrule->rfcString()); // FREQ need to be 'MONTHLY' not 2

[rlanvin]

Hello,

Thank you for this. The code you are showing is working just fine for me though. Based on your pull request, I'm guessing that the bug you are describing occurs when using the constant RRule::MONTHLY to set the frequency, instead of the string 'MONTHLY'. Is that it?

Before I merge, could you write a test that demonstrate the bug and add it to your PR?

Also, it's kind of a minor thing but still... I use snake case for the variables names, so $frequencyKey should be $frequency_key.

Thanks!

[antitoine]

In making these tests, I understood why I needed this modification.
I create a new rule by using the frequency constant in RRule (like RRule::YEARLY), so the integer value is stored in the object and is directly displayed in the RFC string.
Maybe, it will be better if you convert the integer to the real frequency value at the creation of the RRule ?

I hope this new commit meets your expectations

[rlanvin]

Maybe, it will be better if you convert the integer to the real frequency value at the creation of the RRule ?

Internally it's easier to work with integers and constants. Your fix is the right way to do it. Thanks!