Add optional output directory argument to generators #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilities which create files determine their location by either having the user explicitly specify the filenames (using command-line arguments for example) or by at least specifying the output directory to which the files should be saved. Current test generators always put hardcoded filenames into the current working directory. This is inflexible. This behavior is understandable, because test programs shouldn't be held to the same standard as user-facing CLI utilities, however, this issue happens to negatively affect Meson integration. This isn't a bug fix, the old behavior is fully functional.
meator
changed the title
|
looks good, thank you. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discussed this change in #5.
Utilities which create files determine their location by either having the user explicitly specify the filenames (using command-line arguments for example) or by at least specifying the output directory to which the files should be saved.
Current test generators always put hardcoded filenames into the current working directory. This is inflexible. This behavior is understandable, because test programs shouldn't be held to the same standard as user-facing CLI utilities, however, this issue happens to negatively affect Meson integration.
This isn't a bug fix, the old behavior is fully functional.
I have done extensive testing of this system on Windows. I can confirm that localisation of error messages and filesystem paths containing unicode characters work as expected.
I have also verified that this change fixes the issues I've had with Meson integration (briefly touched upon at #5).