Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Frozen String Literal warnings in Ruby 3.4 #76

Open
plicjo opened this issue Jan 2, 2025 · 1 comment · May be fixed by #78
Open

Frozen String Literal warnings in Ruby 3.4 #76

plicjo opened this issue Jan 2, 2025 · 1 comment · May be fixed by #78

Comments

@plicjo
Copy link

plicjo commented Jan 2, 2025

The string mutation methods are throwing warnings in Ruby 3.4.
@gstokkink
Copy link

gstokkink commented Jan 16, 2025 •
edited
Loading

Running into this as well. Looks like this could be easily fixed by having strip_string call value.dup before mutating it further.

@rmm5t what do you think? I'll create a PR.

gstokkink added a commit to bookingexperts/strip_attributes that referenced this issue Jan 16, 2025
@gstokkink
Call .dup on string before modifying it in-place.
33c28f6 
Prevents Ruby 3.4 frozen string warnings.

Fixes rmm5t#76.
@gstokkink gstokkink linked a pull request Jan 16, 2025 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call .dup on string before modifying it in-place. bookingexperts/strip_attributes
2 participants
@plicjo @gstokkink