-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improved web Camera #3473
Improved web Camera #3473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me!
Pls fix lint errors
Implemented all methods of CameraRef except SetCamera and implemented zoom CameraProps
Done, although the lint errors were like: |
Thanks, yeah I hear you. I'm not 100% about this lint rule either. I think it's not something we use directly, but we're inheriting it from rn preset, in that case I'd vote for keeping it just for consistency with rn projects, otherwise I'm fine with removing that lint rule. |
Description
Implemented all methods of CameraRef except SetCamera and implemented zoom CameraProps
Checklist
CONTRIBUTING.md