feat: add symbolZOffset to symbol layer #3802
Open
+87
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
symbol-z-offset
I've filled the values in
v8.json
based on other values I saw there. I don't exactly know what each field should be (especially inexpression
andproperty-type
), so I'm not 100% certain that these are correct.Also, at some point
yarn generate
added the values at the right places, but for some reason it doesn't anymore for me at the moment and removes everything except for the entry inv8.json
. I'm probably doing something wrong here, but I've restored what was initially added byyarn generate
.Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
app as I couldn't get it to build, but it does work in our own application FWIW (with both V11 and New Architecture enabled)./example
)Screenshot OR Video
with.mov
without.mov