issue of "Collection<> was mutated while being enumerated" has fixed

[AlifKuan]

Hi
I found one crash while using xmppframework 3.6.6
I think this issue has casued because it tries to delete "earlyPresenceElements" while being enumerated
That's why I modified code and updated the fork
Please check it and let me know your idea

Regards
Alif Kuan

[adozenlines]

I believe this patch must be rejected as this change allows for duplicate presence items to sent back the client... What a fix for this issue should entail is a test items more than zero prior to the removeallobjects.

Sent from my iPhone

On Nov 13, 2015, at 8:33 PM, AlifKuan notifications@github.com wrote:

Hi
I found one crash while using xmppframework 3.6.6
I think this issue has casued because it tries to delete "earlyPresenceElements" while being enumerated
That's why I modified code and updated the fork
Please check it and let me know your idea

Regards
Alif Kuan

You can view, comment on, or merge this pull request online at:

#630

Commit Summary

issue of "Collection<> was mutated while being enumerated" has fixed
File Changes

M Extensions/Roster/XMPPRoster.m (17)
Patch Links:

https://github.com/robbiehanson/XMPPFramework/pull/630.patch
https://github.com/robbiehanson/XMPPFramework/pull/630.diff
—
Reply to this email directly or view it on GitHub.

[adozenlines]

This could be more of an issue related to the number of threads being dispatched and no synchronized behaviour for the collection.

Sent from my iPhone

On Nov 13, 2015, at 8:33 PM, AlifKuan notifications@github.com wrote:

Hi
I found one crash while using xmppframework 3.6.6
I think this issue has casued because it tries to delete "earlyPresenceElements" while being enumerated
That's why I modified code and updated the fork
Please check it and let me know your idea

Regards
Alif Kuan

You can view, comment on, or merge this pull request online at:

#630

Commit Summary

issue of "Collection<> was mutated while being enumerated" has fixed
File Changes

M Extensions/Roster/XMPPRoster.m (17)
Patch Links:

https://github.com/robbiehanson/XMPPFramework/pull/630.patch
https://github.com/robbiehanson/XMPPFramework/pull/630.diff
—
Reply to this email directly or view it on GitHub.

[cleanandsober]

@adozenlines I'm not sure how to address the number of threads dispatched, is this something you'd be able to help with please? According to crashlitics reports -- this particular code definitely is causing major number of crashes to our application in production. And we do want to address the issue properly and the best possible way. So any help addressing this issue would be hugely appreciated.