Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make skypilot optional for inference-cli #792

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

sberan
Copy link
Contributor

@sberan sberan commented Nov 8, 2024

Description

Skypilot is a fairly large dependency of inference-cli that is not frequently used by most users. In this PR, I am adding it as an optional dependency and I added error messages to guide the user toward installing these dependencies if needed.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested locally

Any specific deployment considerations

n/a

Docs

  • Docs updated? What were the changes:

Copy link
Contributor

@bigbitbus bigbitbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit 84f9a94 into main Nov 11, 2024
71 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the skypilot-optional branch November 11, 2024 06:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants