Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix return value when sv.Detections is empty #430

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix return value when sv.Detections is empty #430

merged 2 commits into from
Oct 6, 2023

Conversation

akashpambhar
Copy link
Contributor

Description

Fixes #429. When sv.Detections is empty (len(detections) == 0) sv.ByteTrack returns np.array([], dtype=int)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-actions[bot]
github-actions bot reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.

@onuralpszr onuralpszr added enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti api:tracker labels Oct 6, 2023
@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 6, 2023

Hi @akashpambhar 👋🏻! Thanks for the PR. 🙏🏻 Let me quickly test if everything works as expected.

SkalskiP
SkalskiP requested changes Oct 6, 2023
View reviewed changes
supervision/tracker/byte_tracker/core.py Outdated Show resolved Hide resolved
@SkalskiP SkalskiP self-requested a review October 6, 2023 22:03
@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 6, 2023

Tested! Now, we are ready to merge. 👍🏻

@SkalskiP SkalskiP merged commit c5c37e4 into roboflow:develop Oct 6, 2023
6 checks passed
@onuralpszr onuralpszr added the hacktoberfest-accepted Contribute to the notion of open-source this October! label Oct 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@SkalskiP SkalskiP SkalskiP approved these changes

Assignees
No one assigned
Labels
api:tracker enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti hacktoberfest-accepted Contribute to the notion of open-source this October!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sv.ByteTrack.tracker_id return value when sv.Detections is empty
4 participants
@akashpambhar @CLAassistant @SkalskiP @onuralpszr