Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Publish javadoc for Robolectric 4.12.2 #263

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

  • Add javadoc for Robolectric 4.12.2.

  • Update mkdocs.yml to add a navigation entry to the new javadoc.

  • Update mkdocs.yml to use version 4.12.2.

Fixes #2382144206

- Add javadoc for Robolectric 4.12.2.

- Update mkdocs.yml to add a navigation entry to the new javadoc.

- Update mkdocs.yml to use version 4.12.2.

Fixes #2382144206
@MGaetan89
Copy link
Member

@utzcoz @hoisie here's a PR created from the publish-javadoc workflow.

I see that the Fixes #xxx in the PR description points to the wrong issue. I'll send a PR to fix that.
If you notice something else that's wrong or could be improved, let me know, and I'll address it too.

@utzcoz
Copy link
Member

utzcoz commented Jun 30, 2024

@MGaetan89 Looks like it replaces the 4.12 directory instead of a new directory.

@MGaetan89
Copy link
Member

@MGaetan89 Looks like it replaces the 4.12 directory instead of a new directory.

I thought that was the expected behaviour. But what you want is to have one folder per version, even for patch releases, right?
So we'd have a 4.12 folder, as well as a 4.12.2 folder?

If so, does it mean that in the menu, we have an entry for both 4.12 and 4.12.2?

@MGaetan89 MGaetan89 linked an issue Jun 30, 2024 that may be closed by this pull request
@utzcoz
Copy link
Member

utzcoz commented Jun 30, 2024

So we'd have a 4.12 folder, as well as a 4.12.2 folder?

Yeah. Every version should have it separate directory. There might have some minor API changes between main version and patch version.

Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check whether the approve can make CI continue for this PR.

Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI doesn't work as expected.

@utzcoz
Copy link
Member

utzcoz commented Jun 30, 2024

https://github.com/orgs/community/discussions/55906 Looks like it is related to GITHUB_TOKEN.

@MGaetan89
Copy link
Member

So we'd have a 4.12 folder, as well as a 4.12.2 folder?

Yeah. Every version should have it separate directory. There might have some minor API changes between main version and patch version.

Got it, I'll update the workflow accordingly. It'll make things easier then.

github.com/orgs/community/discussions/55906 Looks like it is related to GITHUB_TOKEN.

Thanks for the link. So we need a dedicated token to be created and added to this repository setting, so we can use it in the workflow, right?

@utzcoz
Copy link
Member

utzcoz commented Jun 30, 2024

So we need a dedicated token to be created and added to this repository setting, so we can use it in the workflow, right?

From the discussion, I think yes. We can move to discuss it to Slack, and check whether we can add a special token for it or we have other approaches.

@MGaetan89
Copy link
Member

Closing this PR, as a new version will be submitted once #264 is merged.

@MGaetan89 MGaetan89 closed this Jun 30, 2024
@MGaetan89 MGaetan89 deleted the publish-javadoc-robolectric-4.12.2 branch June 30, 2024 09:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish javadoc for 4.12.2
2 participants