Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ergoCubSN003 configuration files #710

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

martinaxgloria
Copy link
Contributor

As per the title, this PR adds the configuration files for ergoCubSN003. It's basically the same as ergoCubSN002 but with the new neck mk3.

cc @Nicogene @pattacini

@martinaxgloria martinaxgloria self-assigned this Feb 7, 2025
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinaxgloria

Can you update also the all_robots.xml file in the root?
Further, how did you deal with the neck files? Are the PID gains the same as those tuned by @SanLordKevin?

@martinaxgloria
Copy link
Contributor Author

Can you update also the all_robots.xml file in the root?

Yes, my bad I forgot it

Further, how did you deal with the neck files? Are the PID gains the same as those tuned by @SanLordKevin?

Yes, the PID gains are the same for the time being

@pattacini
Copy link
Member

The CI is failing with the following logs:

@SanLordKevin
Copy link
Contributor

Can you update also the all_robots.xml file in the root? Further, how did you deal with the neck files? Are the PID gains the same as those tuned by @SanLordKevin?

The PID are the one tuned before the orin installation. I will retune them.

@pattacini
Copy link
Member

pattacini commented Feb 8, 2025

The CI is still failing.
You can find the log attached to the CI workflow.

@martinaxgloria
Copy link
Contributor Author

Now the CI is happy😄

@pattacini
Copy link
Member

Thanks heaps @martinaxgloria

The PID are the one tuned before the orin installation. I will retune them.

Hi @SanLordKevin,
I would merge the PR anyway to speed up things. You could amend the gains later on.

@martinaxgloria, if there ain't setbacks preventing from marking the PR ready, you can proceed.

@martinaxgloria martinaxgloria marked this pull request as ready for review February 10, 2025 09:16
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes are required.
See inline comments.

@pattacini pattacini merged commit 008a951 into robotology:devel Feb 10, 2025
2 checks passed
@martinaxgloria martinaxgloria deleted the feat/add_ergoCubSN003 branch February 10, 2025 10:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants