-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add ergoCubSN003 configuration files #710
Add ergoCubSN003 configuration files #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martinaxgloria
Can you update also the all_robots.xml
file in the root?
Further, how did you deal with the neck files? Are the PID gains the same as those tuned by @SanLordKevin?
Yes, my bad I forgot it
Yes, the PID gains are the same for the time being |
The CI is failing with the following logs: |
The PID are the one tuned before the orin installation. I will retune them. |
The CI is still failing. |
ae10217
to
b64d2c4
Compare
Now the CI is happy😄 |
Thanks heaps @martinaxgloria
Hi @SanLordKevin, @martinaxgloria, if there ain't setbacks preventing from marking the PR ready, you can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fixes are required.
See inline comments.
As per the title, this PR adds the configuration files for ergoCubSN003. It's basically the same as ergoCubSN002 but with the new
neck mk3
.cc @Nicogene @pattacini