Audio volume #2433
Merged
Audio volume #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randaz81
added
PR Type: Feat/Enh
randaz81
force-pushed
the
audio_volume
branch
from
51e7dba to
5c6f91d
Compare
This comment has been minimized.
This comment has been minimized.
|
randaz81
force-pushed
the
audio_volume
branch
3 times, most recently
from
4263065 to
5f1f6f7
Compare
randaz81
force-pushed
the
audio_volume
branch
from
5f1f6f7 to
ad89baf
Compare
randaz81
force-pushed
the
audio_volume
branch
from
6814c82 to
1a031fb
Compare
|
The following devices have been tested:
The PR could be merged only after all of these devices have been tested |
This comment has been minimized.
This comment has been minimized.
randaz81
force-pushed
the
audio_volume
branch
from
45b8e86 to
10ca1b0
Compare
This comment has been minimized.
This comment has been minimized.
…: amplifyChannel(), amplify(), findPeakInChannel(), findPeak(), normalizeChannel(), normalize() * Added SoundTest to harness_sig
* Added the new class `AudioPlayerDeviceBase`, all playback device drivers now derive from this class. * Added the new methods to `setHWGain()`, `setHWGain()` to `IAudioRender` interface. * Added the new methods to `setHWGain()`, `setHWGain()` to `IAudioGrabberSound` interface.
Improved `AudioPlayerDeviceBase` and `AudioRecorderDeviceBase` classes to remove duplicated code (e.g. parameters parsing and render modes) Untested.
…arser of the base parameters in the base class
… parsed by AudioPlayerDeviceBase, AudioRecorderDeviceBase classes
…derStatus.h some logic related to playback autostart has been completely removed PortAudioPlayerDeviceDriver has been successfully test
virtual bool IAudioRender::isPlaying(bool& playback_enabled) = 0; virtual bool IAudioGrabberSound::isRecording(bool& recording_enabled) = 0; they have been implemented in AudioPlayerDeviceBase and AudioRecorderDeviceBase AudioPlayerWrapper and AudioRecorderWrapper now asks the status to the device
…iceBase: it waits in a loop until the buffer size is zero (all the audio samples have been consumed) fakeSpeaker logic of buffere management improved fakeSpeaker successfully tested
…to prevent access to not yet allocated audio buffer * audioToFileDevice cleanup + added support to write .mp3 files * audioToFileDevice successfully tested
…of the device and to get the audio data from the device
…re the two recording channels. PortAudioRecorderDeviceDriver successfully tested. Audio from PortAudioRecorderDeviceDriver successfully played onto PortAudioPlayerDeviceDriver
…m_irender==nullptr if the device was not successfully initialized
…ult: false) and `audioRecorderDeviceBase` (default: true)
…O_BASE::debug for all audio devices *General cleanup *Fixed number of channels for audioFromFileDevice *AudioFromFileDevice successfully test
|
Merged, thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarp::sig
yarp::sig::soundadded the following methods: amplifyChannel(), amplify(), findPeakInChannel(), findPeak(), normalizeChannel(), normalize()harness_sig: added tests to check the new methodsyarp::dev
yarp::dev::audioRecorderStatusandyarp::dev::audioPlaybackStatusgenerated by thrift.AudioPlayerDeviceBase, all playback device drivers now derive from this class.AudioRecorerDeviceBase, all recording device drivers now derive from this class.setHWGain(),setSWGain()toIAudioRenderinterface.setHWGain(),setSWGain()toIAudioGrabberSoundinterface.Devices
AudioPlayerWrapperandAudioRecorderWrapper, to control the volume via setHWGain(),setSWGain()`AudioPlayerWrapperandAudioRecorderWrappernow broadcast their internal status on a xxx/status:o portaudioToFileDevice,fakeSpeaker,portaudioPlayer,now derive fromAudioPlayerDeviceBase.audioFromFileDevice,fakeMicrophone,portaadioRecorder, now derive fromAudioRecorderDeviceBase.