some refactorings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amily as input note that previously os_family and os_distribution were used: "bsd", "freebsd" -> pkg "debian", _ -> apt and now, os and os_family are used: "freebsd", _ -> pkg "linux", "debian" -> apt
hannesm
commented
Aug 8, 2024
| | _ -> None | ||
| in | ||
| OpamFilter.filter_formula ~default:false env depends |
There was a problem hiding this comment.
the reason to remove this ~default:false is that we notice future missing variables. we can re-add it if it is annoying.
the code is called from Orb with a try .. catch anyways, thus the filter_formula raising an exception is handled.
hannesm
commented
Aug 8, 2024
| "OS_DISTRIBUTION", vars.os_distribution; | ||
| "OS_VERSION", vars.os_version; | ||
| "OS_FAMILY", vars.os_family; | ||
| "ARCH", vars.arch; |
There was a problem hiding this comment.
we now include arch as well.
hannesm
commented
Aug 8, 2024
| log "unsupported OS (no system packages), bsd without distribution" | ||
| end | ||
| | Some "debian" -> | ||
| let dump_system_packages ~os ~os_family filename = |
There was a problem hiding this comment.
as mentioned in the commit message, using os and os_family looks sufficient (for now).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also fixes #16