Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable nano unit for CPU requests #356

Open
Letme opened this issue Nov 4, 2024 · 5 comments
Open

Enable nano unit for CPU requests #356

Letme opened this issue Nov 4, 2024 · 5 comments

Comments

@Letme
Copy link

Letme commented Nov 4, 2024

Is your feature request related to a problem? Please describe.
I feel like CPU Requests has a 10m minimum, while Memory requests has 100Mi minimum. I have much smaller requests by default as my cluster also holds not that much usage intensive websites.

Describe the solution you'd like
Make possibility to say minimum - not to suggest increase to 10m for each usage. I would also go into a nano perspective in such case, and not round to 1m as it happens now

Describe alternatives you've considered
I have simply discarded those suggestions, but it prevents automation.

Are you interested in contributing a PR for this?
I can provide improvements.

Additional context
My cluster has many pods running on 0.8m CPU requests, which then enables better utilization of the available CPU power as simple nginx webserver with PHP or python never uses 10m CPU per container.

@aantn
Copy link
Contributor

aantn commented Nov 4, 2024

Hi @Letme, you should be able to adjust that with --cpu-min and --mem-min flags. You can see more info w/ krr simple --help

Let me know if that works! I don't think we have a flag regarding the rounding but please feel free to open a PR and we'd be happy to review!

@Letme
Copy link
Author

Letme commented Nov 5, 2024

That is a solution, indeed. But it does only work with integer, so smallest unit is 1m for CPU. Does anyone use nano or is that just me?

@aantn
Copy link
Contributor

aantn commented Nov 5, 2024

If you are doing it, there are surely others! But we've only used 1m as the smallest amount.

@Letme Letme changed the title CPU and memory requests have hardcoded minimums? Enable nano unit for CPU requests Nov 7, 2024
@Letme
Copy link
Author

Letme commented Nov 7, 2024

Ok, I have changed the topic of this issue, so that that is more reflected. When I have time I will look a bit if I can easily add nano units to the script.

@aantn
Copy link
Contributor

aantn commented Nov 7, 2024 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants