Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(namespace): regex match #336

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

iomarmochtar
Copy link
Contributor

This MR will add ability in selecting some namespaces that will be scanned by using regex pattern

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024

CLA assistant check
All committers have signed the CLA.

@iomarmochtar
Copy link
Contributor Author

cc: @aantn for review

Copy link
Contributor

@aantn aantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Left some comments to address please.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
robusta_krr/core/integrations/kubernetes/__init__.py Outdated Show resolved Hide resolved
@aantn
Copy link
Contributor

aantn commented Oct 13, 2024

Just to update you on the status, we got a little delayed in reviewing this but someone from the team will review soon!

@iomarmochtar iomarmochtar force-pushed the namespace-regex-match branch from 9ecaff8 to fb03c23 Compare October 15, 2024 00:50
Copy link
Contributor

@itisallgood itisallgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

@itisallgood itisallgood merged commit f171a4d into robusta-dev:main Oct 24, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants